Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs fix/cypress/1251 #1254

Merged
merged 5 commits into from
Oct 6, 2023
Merged

Bugs fix/cypress/1251 #1254

merged 5 commits into from
Oct 6, 2023

Conversation

Angra974
Copy link
Contributor

@Angra974 Angra974 commented Sep 25, 2023

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Cypress test fails because it tests twitter tweets but the tweets were replaced by the testimonial.

On localhost, sometimes contributors test fails too.

Sometimes tests fail just because of the timeout is too short
Fixes #1251

Type of change

Replace the current tests by new one for homepage.
Add minimum test for leaderboard and ideas.
Add a longer timeout to cypress config

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Use it another branch where tests are done before push
Run locally with cypress:run too

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

run cypress:run

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots or example output

image

image

image

image

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 8:20am

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for reactplayio failed.

Name Link
🔨 Latest commit dad2e1e
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/651fc0d8d0fba50008821729

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@priyankarpal priyankarpal linked an issue Sep 29, 2023 that may be closed by this pull request
4 tasks
@priyankarpal priyankarpal assigned atapas and unassigned atapas Sep 29, 2023
@joshi-kaushal
Copy link
Member

Hi @Angra974 can you please merge the latest changes from main?

@priyankarpal priyankarpal merged commit 4c13c5a into main Oct 6, 2023
1 of 7 checks passed
@priyankarpal priyankarpal deleted the bugsFix/cypress/1251 branch October 6, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: cypress test fails
4 participants